search

filecoin-project / rust-fil-proofs

Proofs for Filecoin in Rust
Other
492 stars 314 forks source link

feat: benchy window-post add parallels tasks #1686

Closed lovel8 closed 1 year ago

lovel8 commented 1 year ago

feat: benchy window-post add parallels tasks

vmx commented 1 year ago

Can you please explain a bit more about this feature? Wouldn't it be the same as running benchy manually in parallel?

vmx commented 1 year ago

In regards to CI not running. CircleCI is weird. You probably have CircleCI configured to run on the fork you have. In order to get CircleCI run here, you'd need to unfollow your fork in the CircleCI UI.

lovel8 commented 1 year ago

Can you please explain a bit more about this feature? Wouldn't it be the same as running benchy manually in parallel?

  1. The functions are the same, but it is more convenient to run only one program and run 30 programs at the same time in each concurrent test.
  2. The concurrency test runs only one program, which is consistent with the actual business concurrency usage, and the test results are more in line with expectations.
lovel8 commented 1 year ago

In regards to CI not running. CircleCI is weird. You probably have CircleCI configured to run on the fork you have. In order to get CircleCI run here, you'd need to unfollow your fork in the CircleCI UI.

image

vmx commented 1 year ago

@lovel8 were you always not following or did you change to not follow? In case you changed, can you try to push again? Easiest is to do a git commit --amend and then push that new commit.

In case you didn't ever follow your own fork, then I've no idea what the problem is. In the meantime I've pushed that branch so that CI runs. You can see the results here: https://app.circleci.com/pipelines/github/filecoin-project/rust-fil-proofs/4656/workflows/9177d9c2-9f2d-478d-a3e5-0c654698a49a