search

filecoin-project / rust-fil-proofs

Proofs for Filecoin in Rust
Other
492 stars 314 forks source link

fix: TreeD size and rows to discard calculation was wrong #1692

Closed vmx closed 1 year ago

vmx commented 1 year ago

For the TreeD the amount of nodes for the full merkle tree and not for the subtrees needs to be used. The node_count variable was shadowed by another instance. This is fixed by renaming the initial variable.

vmx commented 1 year ago

Fortunately for TreeD it's a no-op.

What is a no-op? The rows to discard?

cryptonemo commented 1 year ago

Fortunately for TreeD it's a no-op.

What is a no-op? The rows to discard?

The value passed in (the 'bug') isn't used.