search

filecoin-project / rust-fil-proofs

Proofs for Filecoin in Rust
Other
489 stars 314 forks source link

Allow sealing without t_aux files #1717

Closed vmx closed 10 months ago

vmx commented 1 year ago

This PR introduces a new feature called fixed-rows-to-discard, when enabled, no t_aux files are written or read. It contains quite a lot of changes as some refactorings lead to less StoreConfigs and hence make it easier to reason about the whole change that it still does the correct thing.

This PR supersedes https://github.com/filecoin-project/rust-fil-proofs/pull/1715.

vmx commented 12 months ago

As requested on a side-channel, let's start with a PR with the refactorings first. That can be found at https://github.com/filecoin-project/rust-fil-proofs/pull/1719.

vmx commented 12 months ago

I've put this into draft state, as it'll be split into several PRs. Once those a merged, I'll rebase that one and mark it then again ready for review.

vmx commented 10 months ago

Ready for review. It's different from the precious version as all the refactors leading to this PR were already merged. From the commit message:

If the fixed-rows-to-discard feature is enabled, then TreeR has a fixed number of rows discarded (2). There is not option to change that value. This also means that we no longer need to persist the TemporaryAux file t_aux. This code path will neither read nor write such a file.