search

filecoin-project / rust-fil-proofs

Proofs for Filecoin in Rust
Other
489 stars 314 forks source link

`sha2raw` fails to build in Windows on an ARM device #1718

Open jdjaustin opened 12 months ago

jdjaustin commented 12 months ago

Description

sha2raw fails to build in Windows on an ARM device. Removing the default asm feature from sha2raw/Cargo.toml allows the crate to build.

Acceptance criteria

sha2raw builds without error in Windows on an ARM device.

Risks + pitfalls

Where to begin

vmx commented 12 months ago

It's cool to hear that sha1raw it can be built under Windows on ARM without any further changes. Is anything missing then or can this issue be closed?

jdjaustin commented 12 months ago

It's cool to hear that sha1raw it can be built under Windows on ARM without any further changes. Is anything missing then or can this issue be closed?

I'm not sure I understand. In Windows on ARM, sha2raw currently fails to build without manually disabling the default asm feature. The crate would need to check the architecture and disable asm under Windows on ARM to build without manual changes.

vmx commented 12 months ago

Thanks for the clarification, so you try to build rust-fil-proofs as a whole under Windows on ARM?

Currently Windows is not supported and we have no intention to do. Though if PRs are provided that make it easier to build on unsupported platforms like Windows, without causing issues for the currently supported platforms, we are happy to review and merge those.