search

filecoin-project / rust-fil-proofs

Proofs for Filecoin in Rust
Other
489 stars 314 forks source link

refactor: refactor p_aux/t_aux handling into the util module #1721

Closed vmx closed 10 months ago

vmx commented 11 months ago

p_aux and t_aux is dealt with throughout the code. In the update proofs API they are nicely put into functions. Move those functions into the common utility module and then use those in all places.

The update proofs API puts a restriction on using the Poseidon hasher. This restriction is kept as it makes sense for all cases where p_aux and t_aux is used.

vmx commented 11 months ago

To me it made sense to restrict it to the PoseidonHasher. I think it made things clearer. Though it would be a breaking change for filecoin proofs API, hence I'll redo that PR without restricting things to the PoseidonHasher.

vmx commented 11 months ago

Ready for review, it doesn't contain any breaking changes now.

DrPeterVanNostrand commented 10 months ago

Looks good to me, but Nemo should probably also do a final review.