search

filecoin-project / rust-fil-proofs

Proofs for Filecoin in Rust
Other
489 stars 314 forks source link

fix: remove wrong assert in Synth PoRep code path #1750

Closed vmx closed 5 months ago

vmx commented 5 months ago

Due to me understanding the code wrongly during the refactoring at https://github.com/filecoin-project/rust-fil-proofs/pull/1720, there was a wrong assert inserted into the code. With removing this assert the lifecycle 32GiB test as well as the benchy synthetic proofs generation works as expected again.

This commit also updates the README with the correct command to run benchy for synthetic proofs generation.

Fixes #1749.

cryptonemo commented 5 months ago

Looks good to me, just with the caveat that this change is included in #1748.

Correct. @vmx and I already know we did duplicate work here. #1748 will replace this though.

vmx commented 5 months ago

The fix was merged with #1748.