search

filecoin-project / rust-fil-proofs

Proofs for Filecoin in Rust
Other
489 stars 314 forks source link

fix: remove challenge seed from NI-PoRep SnarkPack transcript #1755

Closed DrPeterVanNostrand closed 4 months ago

DrPeterVanNostrand commented 4 months ago

Alternative to #1754. This PR proposes that any PoRep challenge seed(s) (provided as API arguments) not be included in NI-PoRep's SnarkPack transcript, as opposed to using a constant value for NI-PoRep's challenge seed.

Imho, merging of either PR should be held off until a decision is made during the NI-PoRep audit.

cryptonemo commented 4 months ago

Would it make sense to refactor the hash calculation into its own function, so that it's again clearer that it does exactly the same thing for proving as well as for verification?

It used to be a separate function and review feedback implied it wasn't needed to be a separate function. Also, no, it's pretty clear as it is.

DrPeterVanNostrand commented 4 months ago

I think it would make sense to add a comment to the entry point of the sealing

Yup, sounds like a good idea. I'll add it.