filecoin-project / rust-fil-proofs

Proofs for Filecoin in Rust
Other
489 stars 314 forks source link

feat: expose an API suitable for NI-PoRep proof aggregation #1757

Closed cryptonemo closed 4 months ago

cryptonemo commented 4 months ago

feat: add tests to ensure NI-PoRep is tested w and w/o aggregation

cryptonemo commented 4 months ago

Just making sure I understand correctly what this is about. In the last step of the Ni-PoRep we aggregate the proofs. We cannot aggregate aggregated proofs. Hence if we want to aggregate several Ni-PoReps, we need the unaggregated result and then aggregate all of them. Is that correct?

Correct, it's specified in the FIP, but wasn't in the implementation. Fortunately it was caught before shipping.