search

filecoin-project / rust-fil-proofs

Proofs for Filecoin in Rust
Other
489 stars 314 forks source link

feat: update FIP92 min value to proposed new value #1758

Closed cryptonemo closed 2 months ago

cryptonemo commented 3 months ago

feat: add negative bounds checking test feat: add a 32GiB max value ni-porep aggregation test

In case this is needed in reference to https://github.com/filecoin-project/FIPs/pull/1018

BigLep commented 3 months ago

@vmx : if @cryptonemo is out this week, can you please take on merging? Also, (newbie question) are there any followup steps needed for releasing this change?

vmx commented 3 months ago

@BigLep I could merge, but @cryptonemo needs to do a release in order to be picked up by the FFI. So I leave it open as a reminder, so that he can do a release when he's back.

BigLep commented 3 months ago

@vmx : thanks! Just to make sure I'm following, in order to be able to start Butterfly testing we need to:

  1. merge this PR
  2. do a release of rust-fil-proofs
  3. update https://github.com/filecoin-project/filecoin-ffi/pull/459 with the rust-fil-proofs release so it can be merged
  4. do a filecoin-ffi release ... (not sure of other steps - I don't think critical for this conversation)
  5. update Lotus

If that sequence above is correct, doing the rust-fil-proofs release will be blocking right? So that @rjan90 can start Butterly testing the EU morning of Monday, 2024-06-17, can rust-fil-proofs be released before end of the week (EOD 2024-06-14)?

vmx commented 3 months ago

can rust-fil-proofs be released before end of the week (EOD 2024-06-14)?

Nope, this has to wait till 2024-06-18 when @cryptonemo is available again.

BigLep commented 2 months ago

@cryptonemo : are you able to merge and release now?