search

filecoin-project / rust-fil-proofs

Proofs for Filecoin in Rust
Other
489 stars 314 forks source link

feat: use workspace inheritance for dependencies #1760

Closed kamuik16 closed 1 month ago

kamuik16 commented 1 month ago

Closes #1645

cc @vmx

kamuik16 commented 1 month ago

Thanks! It generally looks good, I only found two small things.

I also compared the generated Cargo.lock file to the one the master branch creates. It's identical which indicates that things are correct.

Thanks for the review. Fixed suggestions in https://github.com/filecoin-project/rust-fil-proofs/pull/1760/commits/8774e06bbbe5c189c430412e901fbe972184f9d0.