search

filecoin-project / specs-actors

DEPRECATED Specification of builtin actors, in the form of executable code.
Other
86 stars 102 forks source link

multiple cc upgrades to the same sector #1035

Open acruikshank opened 4 years ago

acruikshank commented 4 years ago

Problem

As pointed out in #1021, multiple sectors can claim to be a CC upgrade for the same sector. Since the only benefit of a CC upgrade is to allow a sector to expire early, more than one CC upgrade for the same sector does little for the miner. It could however result in an initial pledge and termination fee increase that is unnecessarily high. The questions for this issue:

  1. Do we care at all? Miners should be able to avoid replacing the same sector.
  2. Do we care enough to fix it? Detecting this condition for sectors proven in the same epoch is relatively easy, but detecting it in multiple sectors will probably require additional miner state.
anorth commented 4 years ago

Thanks for opening the discussion. @nicola @zixuanzh do you have opinion here?

My opinion is that miners should be able to avoid it, the expected cost is thus low, and so not worth adding complexity for.

zixuanzh commented 4 years ago

I see, we are less concerned about this given that sector upgrades require a reseal. It will be a bigger problem if sector upgrade becomes much cheaper.