search

filecoin-project / specs-actors

DEPRECATED Specification of builtin actors, in the form of executable code.
Other
86 stars 102 forks source link

Why need a ConsensusFaultElapsed? #1393

Closed hoplover closed 3 years ago

hoplover commented 3 years ago

In ReportConsensusFault, there exist a ConsensusFaultElapsed that protect the miner not to be slashed during this time. And the time lasts for a whole ChainFinality, does it make sense? On one hand, a bad miner can mine lots of blocks during this duration, he will never be punished, which causes a safety problem. On another hand, it's not hard to just record slashed epoch to avoid a double slash problem in tech.

Stebalien commented 3 years ago

That actually defines the period of time in which the miner cannot mine. This restriction is enforced in lotus, not specs-actors.

On one hand, a bad miner can mine lots of blocks during this duration, he will never be punished, which causes a safety problem.

Note: The safety/correctness analysis of Filecoin doesn't actually rely on slashing. My understanding is that this feature mostly helps the chain converge faster.