Closed ZenGround0 closed 3 years ago
Out of curiosity, why did you elect to write a scenario test rather than a unit test for testing the ProveCommitAggregate with a expired sector?
With the upcoming test vectors project all scenario tests will now generate conformance tests so I now have a slight bias towards testing with scenario tests if it is not too hard to do. In this case I was already warmed up writing similar tests from measuring aggregate porep gas so it seemed worth the extra effort.
Merging #1412 (fa31738) into spike/aggregate-porep (418e07d) will increase coverage by
0.0%
. The diff coverage is81.2%
.
@@ Coverage Diff @@
## spike/aggregate-porep #1412 +/- ##
=====================================================
Coverage 69.8% 69.8%
=====================================================
Files 72 72
Lines 7700 7792 +92
=====================================================
+ Hits 5378 5446 +68
- Misses 1438 1451 +13
- Partials 884 895 +11
TODO: