filecoin-project / specs-actors

DEPRECATED Specification of builtin actors, in the form of executable code.

Other

86 stars 102 forks source link

Adjust code for subtle change in go-multihash 0.0.15 #1463

Closed ribasushi closed 3 years ago

ribasushi commented 3 years ago

go-multihash is now wrapping the returned error, so the check in the test lib requires an errors.Is https://github.com/multiformats/go-multihash/blob/v0.0.15/core/registry.go#L58-L60

cc @warpfork @mvdan

Stebalien commented 3 years ago

This updates a dependency, so please don't merge until we've cut a v6 branch.

ribasushi commented 3 years ago

@Stebalien I do not have push-access here, can you either gimme or reopen the PR from here? Currently I need to do a replace ... so I can pull from my fork into lotus...

Stebalien commented 3 years ago

Pushed to chore/upgrade_go-multihash

codecov-commenter commented 3 years ago

Codecov Report

Merging #1463 (5d9e79a) into master (ab02f79) will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1463   +/-   ##
======================================
  Coverage    70.2%   70.2%           
======================================
  Files          72      72           
  Lines        7802    7802           
======================================
  Hits         5481    5481           
  Misses       1438    1438           
  Partials      883     883

ribasushi commented 3 years ago

This updates a dependency, so please don't merge until we've cut a v6 branch.

@Stebalien I just realized I do not need to do any of the version bumps. The diff in this PR at the time of writing is sufficient to allow lotus itself to jump to go-multihash v0.0.15

Stebalien commented 3 years ago

Merging because this is a testing only change.