search

filecoin-project / specs-actors

DEPRECATED Specification of builtin actors, in the form of executable code.
Other
86 stars 102 forks source link

Divide once when calculating qa power #1493

Closed ZenGround0 closed 3 years ago

ZenGround0 commented 3 years ago

Fixes #1250

This is already well tested in miner/policy_test.go TestQuality. The high value of SectorQualityPrecision seems to have kept any error from creeping in to the computation, at least in test cases.

codecov-commenter commented 3 years ago

Codecov Report

Merging #1493 (2da52a8) into master (7a69070) will not change coverage. The diff coverage is 100.0%.

@@          Coverage Diff           @@
##           master   #1493   +/-   ##
======================================
  Coverage    71.4%   71.4%           
======================================
  Files          72      72           
  Lines        8546    8546           
======================================
  Hits         6109    6109           
  Misses       1553    1553           
  Partials      884     884
ZenGround0 commented 3 years ago

From @Stebalien this might actually need a migration over partition state to be safe. Investigating...

ZenGround0 commented 3 years ago

This needs a migration for safety. Closing down for now and removing from v14 scope. Putting migration ideas in issue.