search

filecoin-project / specs-actors

DEPRECATED Specification of builtin actors, in the form of executable code.
Other
86 stars 102 forks source link

fix #1248 changing the deal label to bytes not strings #1496

Closed laudiacay closed 3 years ago

laudiacay commented 3 years ago

fix #1248

codecov-commenter commented 3 years ago

Codecov Report

Merging #1496 (26d6f2a) into next (7a69070) will increase coverage by 0.0%. The diff coverage is 90.3%.

@@          Coverage Diff          @@
##            next   #1496   +/-   ##
=====================================
  Coverage   71.4%   71.5%           
=====================================
  Files         72      73    +1     
  Lines       8546    8559   +13     
=====================================
+ Hits        6109    6120   +11     
- Misses      1553    1554    +1     
- Partials     884     885    +1
ZenGround0 commented 3 years ago

@laudiacay this is a good code change. There is an associated data change to mainnet state that will need to also be made through an "actors state migration". See this example PR for one example of how this looks: https://github.com/filecoin-project/specs-actors/pull/1265/files

ZenGround0 commented 3 years ago

This is also something that will need a Fillecoin Improvement Proposal (FIP) to signal the change and give time to implementers of external tooling around deal data. This process takes place here: https://github.com/filecoin-project/FIPs.