filecoin-project / specs-actors

DEPRECATED Specification of builtin actors, in the form of executable code.

Other

86 stars 102 forks source link

Migration to remove existing miners with invalid window post proof types #1508

Closed laudiacay closed 1 year ago

laudiacay commented 3 years ago

see #1474

codecov-commenter commented 2 years ago

Codecov Report

Merging #1508 (1800af7) into next (1cd48d0) will decrease coverage by 0.0%. The diff coverage is 22.2%.

@@           Coverage Diff           @@
##            next   #1508     +/-   ##
=======================================
- Coverage   71.5%   71.4%   -0.1%     
=======================================
  Files         73      73             
  Lines       8565    8572      +7     
=======================================
  Hits        6126    6126             
- Misses      1554    1561      +7     
  Partials     885     885

ZenGround0 commented 2 years ago

Random thought, I think we need to remove these miners from init actor state, not sure if this PR does that yet.

laudiacay commented 2 years ago

It does not. Aaaaaaaaaaaaaagh. I’ll do this tomorrow.

On Wed, Nov 17, 2021 at 10:15 PM ZenGround0 @.***> wrote:

Random thought, I think we need to remove these miners from init actor state, not sure if this PR does that yet.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/filecoin-project/specs-actors/pull/1508#issuecomment-972522877, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACDPMJD373QZE6PVZYWBZADUMR4WVANCNFSM5F6O2HMA .

Stebalien commented 2 years ago

@ZenGround0 are you sure? I'd expect us to mimic the DeleteActor syscall, which doesn't touch the init state. I don't think we currently garbage collect the init actor at all.

ZenGround0 commented 2 years ago

Ah in that case maybe not.