search

filecoin-project / specs-actors

DEPRECATED Specification of builtin actors, in the form of executable code.
Other
86 stars 102 forks source link

State migration for/after SnapDeals implementation #1514

Closed BlocksOnAChain closed 2 years ago

BlocksOnAChain commented 3 years ago

@ZenGround0 will more details for this issue, like we discussed on planning meeting for SnapDeals

ZenGround0 commented 3 years ago

No migration is necessary. However we should consider migrating on chain precommits in st.PreCommittedSectors to remove the update specific fields since cc sector update is now deprecated. We can similarly do this for sector infos though at significantly more migration development cost.

ZenGround0 commented 3 years ago

After discussion with @Kubuxu the intent of the fip is to maintain a record of the original commR to allow for multiple upgrades of sectors with expired deals. This means we need to add room for another commR cid to the sector infos on chain. This requires an upgrade of all sector infos.

Because the costs of doing this are uncertain and probably high we should only add this piece after the rest of the actors implementation is complete.

ZenGround0 commented 2 years ago

Description

SnapDeals introduces some changes to miner state. Most notably a new field to the sector info and a new filed to the deadline. We need a migration included in the upgrade to actors v7 to make this transition possible. We will be transforming the bulk of growing chain data during this operation which will require implementing migrations at a much higher scale than we've seen before since we haven't migrated sector info data in a year and we've added metadata covering an additional ~10EiB since then.

Done Criteria

Dependencies

Ongoing work

No work in progress

arajasek commented 2 years ago

Gonna write up the vanilla migration to enable testing on Lotus, something far more intelligent will be needed though (as noted above)

arajasek commented 2 years ago

Closed in #1532