search

filecoin-project / specs-actors

DEPRECATED Specification of builtin actors, in the form of executable code.
Other
86 stars 102 forks source link

Added Configs for actors #1528

Closed ortyomka closed 1 year ago

ortyomka commented 2 years ago

353

A requirement was to recalculate args after each change in runtime

I have 3 options for solution.

  1. One global config. It looks like antipattern.
  2. Several small configs for each component. Better than big one, because an influence is divided between the policies.
  3. Config for each actor. Several problems here. 3.1. Inconsistency between actor configs 3.2. Values are not recalculated in runtime if some arg changes

I have chosen the second one, but open to your suggestion.

P.S. I am new to Golang: any syntax and semantic suggestions are welcome

ZenGround0 commented 2 years ago

Thanks @ortyomka with my current schedule it will take some time for me to get to reviewing this properly (it could take a month given other priorities) but it is now on my todo list.

FYI @magik6k @arajasek. It will be very helpful to get your opinions on this change as the primary integrators of actors into lotus.

ZenGround0 commented 1 year ago

Apologies we never got this one landed but we're now planning to archive repo. Most of this work seems to be done in the current builtin-actors repo.