filecoin-project / specs-actors

DEPRECATED Specification of builtin actors, in the form of executable code.

Other

86 stars 102 forks source link

FIP-0029 Remove datacap #1546

Closed jennijuju closed 2 years ago

jennijuju commented 2 years ago

Blocked by https://github.com/filecoin-project/go-state-types/pull/34

jennijuju commented 2 years ago

notes from the first review:

[x] add removal nonce to verifreg state （add a map where the key is the <verifier, client>, value is a counter that will increase upon a successful removal
[x] cbor_jen - dont be stupid and type it manually!
[x] check @ZenGround0 's optimicy thing above

ZenGround0 commented 2 years ago

Remaining

[x] Stop existing tests from failing
[ ] Write tests
[ ] Get a migration working

codecov-commenter commented 2 years ago

Codecov Report

Merging #1546 (b1ff110) into master (d479122) will decrease coverage by 0.5%. The diff coverage is 7.5%.

@@           Coverage Diff            @@
##           master   #1546     +/-   ##
========================================
- Coverage    69.6%   69.0%   -0.6%     
========================================
  Files          73      73             
  Lines        8722    8798     +76     
========================================
+ Hits         6077    6079      +2     
- Misses       1784    1858     +74     
  Partials      861     861

arajasek commented 2 years ago

Taking over this PR

arajasek commented 2 years ago

Further test ideas:

bad proposalID fails
bad sig fails
removing more than current cap succeeds, but returns the correct value
calling with not root key fails
calling with siggys from not-verifier fails

arajasek commented 2 years ago

Needs https://github.com/filecoin-project/go-state-types/pull/34