search

filecoin-project / specs

The Filecoin protocol specification
https://spec.filecoin.io
Other
367 stars 170 forks source link

tipset ordering, again #476

Open whyrusleeping opened 5 years ago

whyrusleeping commented 5 years ago

In the past, we decided that the order of the parent cids would be undefined.

This is actually kindof annoying, and I think we should declare a strict order.

The application of messages in blocks is defined as being ordered by the min ticket of each block, but thats hard to use to sort just an array of block cids (dont want to have to load up the blocks).

I propose we sort the cids in the block somehow.

anorth commented 5 years ago

I’m ok with the conceptual overhead of sorting the CIDs lexicographically, differing from message application order.

On Sun, 8 Sep 2019 at 8:37 am, Whyrusleeping notifications@github.com wrote:

In the past, we decided that the order of the parent cids would be undefined.

This is actually kindof annoying, and I think we should declare a strict order.

The application of messages in blocks is defined as being ordered by the min ticket of each block, but thats hard to use to sort just an array of block cids (dont want to have to load up the blocks).

I propose we sort the cids in the block somehow.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/filecoin-project/specs/issues/476?email_source=notifications&email_token=AADMW6TBUK7HXOUSSMGOYV3QIQUJRA5CNFSM4IURPN4KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HJ7JLRQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AADMW6QLGCNEA6VI2XBIJ2TQIQUJRANCNFSM4IURPN4A .

anorth commented 5 years ago

Since this discussion, @whyrusleeping has changed his mind (slack) and Lotus orders parent block CIDs in min-ticket order (though I don't think checks for it on received blocks).