Tests for system exit codes

[alanshaw]

We should test the VM returns the correct system exit codes in certain scenarios. Following is the list of system error codes, scenarios and tests that invoke them. For each exit code we need to define at least one scenario that invokes it and write a corresponding test.

• [x] Ok (0)
  • [x] actor_creation/addresses/sequential-10
  • [x] actor_creation/on_transfer/ok-create-secp256k1
  • [x] actor_creation/on_transfer/ok-create-bls
  • ...and many more
• [x] SysErrSenderInvalid (1)
  • [x] msg_application/invalid_msgs/msg-apply-fail-invalid-nonce
  • [x] msg_application/unknown_actors/msg-apply-fail-unknown-sender
  • [ ] Fail non account actor sender https://github.com/filecoin-project/lotus/blob/932ab61c2df0c0d4a6cf8628f0c0db267f2cae2a/chain/vm/vm.go#L386-L398
    • 
• [x] SysErrSenderStateInvalid (2)
  • [x] actor_creation/on_transfer/fail-secp256k1-insufficient-balance
  • [x] actor_creation/on_transfer/fail-bls-insufficient-balance
  • [x] msg_application/invalid_msgs/msg-apply-fail-invalid-nonce
  • [x] transfer/basic/fail-balance-under-gaslimit
  • [x] transfer/unknown_accounts/fail-unknown-sender-known-receiver
  • [x] transfer/unknown_accounts/fail-unknown-sender-unknown-receiver
• [x] SysErrInvalidMethod (3)
  • [x] msg_application/invalid_msgs/msg-apply-fail-invalid-receiver-method
• SysErrInvalidParameters (4) deprecated in https://github.com/filecoin-project/specs-actors/pull/1018, now SysErrReserved1
  • Transfer to system actor https://github.com/filecoin-project/test-vectors/pull/32
• [x] SysErrInvalidReceiver (5)
  • [x] msg_application/unknown_actors/msg-apply-fail-unknown-receiver
  • [ ] Fail make actor with unknown address protocol https://github.com/filecoin-project/lotus/blob/932ab61c2df0c0d4a6cf8628f0c0db267f2cae2a/chain/vm/mkactor.go#L69-L82
    • 
  • [ ] Fail make runtime message from https://github.com/filecoin-project/lotus/blob/master/chain/vm/vm.go#L125-L127
    • 
• [x] SysErrInsufficientFunds (6)
  • [x] nested/nested_sends/fail-insufficient-funds-for-transfer-in-inner-send
  • [x] transfer/basic/fail-exceed-balance
  • [x] transfer/basic/fail-balance-equal-gas
• [x] SysErrOutOfGas (7)
  • [x] msg_application/gas_cost/msg-apply-fail-receipt-gas
  • [x] msg_application/gas_cost/msg-apply-fail-onchainsize-gas
  • [x] msg_application/gas_cost/msg-apply-fail-transfer-accountcreation-gas
• [x] SysErrForbidden (8)
  • [x] transfer/basic/fail-negative-amount https://github.com/filecoin-project/test-vectors/pull/33
• [x] SysErrorIllegalActor (9)
  • [x] vm_violations/caller_validation/none #39
  • [x] vm_violations/caller_validation/twice #39
  • [ ] Fail to invoke on non builtin actor https://github.com/filecoin-project/lotus/blob/932ab61c2df0c0d4a6cf8628f0c0db267f2cae2a/chain/vm/invoker.go#L68-L71
    • 
  • [ ] Fail to delete unknown actor https://github.com/filecoin-project/lotus/blob/932ab61c2df0c0d4a6cf8628f0c0db267f2cae2a/chain/vm/runtime.go#L257-L262
    • 
  • [ ] Fail send when runtime.Send() disallowed https://github.com/filecoin-project/lotus/blob/932ab61c2df0c0d4a6cf8628f0c0db267f2cae2a/chain/vm/runtime.go#L336-L339
    • 
  • [ ] Fail passing nil to runtime.Transaction() https://github.com/filecoin-project/lotus/blob/932ab61c2df0c0d4a6cf8628f0c0db267f2cae2a/chain/vm/runtime.go#L426-L429
    • 
  • [ ] Fail getting receiver actor for transaction https://github.com/filecoin-project/lotus/blob/932ab61c2df0c0d4a6cf8628f0c0db267f2cae2a/chain/vm/runtime.go#L431-L434
    • 
• [x] SysErrorIllegalArgument (10)
  • [x] msg_application/actor_exec/msg-apply-fail-actor-execution-illegal-arg
  • [ ] Fail create existing singleton actor https://github.com/filecoin-project/lotus/blob/932ab61c2df0c0d4a6cf8628f0c0db267f2cae2a/chain/vm/runtime.go#L227-L229
    • 
• SysErrSerialization (11) deprecated in https://github.com/filecoin-project/specs-actors/pull/1018, now SysErrReserved2
• SysErrorReserved3 (12)
• SysErrorReserved4 (13)
• SysErrorReserved5 (14)
• SysErrorReserved6 (15)

(From https://github.com/filecoin-project/specs-actors/blob/a73a22a48b668c2f5a1cc6a31caef03bcaec5f70/actors/runtime/exitcode/reserved.go#L3-L58)

Note: coverage screenshots above are from the conformance test coverage data, these paths may be exercised in other tests.

[alanshaw]

Good news is that we have at least one test for each exit code. I'm going through the lotus code now and cross referencing with what we have to see if there's scenarios that still need to be tested for.