search

filecoin-project / venus

Filecoin Full Node Implementation in Go
https://venus.filecoin.io
Other
2.06k stars 463 forks source link

Message Syntax/Semantics Validation in fetcher #3312

Closed hannahhoward closed 4 years ago

hannahhoward commented 5 years ago

Description

This is a place holder issue for defining what we want to validate about message / message receipt syntax and semantics. As part of #3232 we're defining an interface for doing syntax validation. This issue is to discuss what should be validated about the syntax, and if a semantic validator should also be build

Acceptance criteria

TBD -- this is for discussion

Risks + pitfalls

Where to begin

This issue needs further definition before it's actionable so the first place is to define what should be validated

anorth commented 5 years ago

This question should be answered in the spec before we can write much useful code. I've filed https://github.com/filecoin-project/specs/issues/464

anorth commented 4 years ago

There is no longer any message semantic validation (until execution), but we still need syntax validation.

anorth commented 4 years ago

Just a thought, maybe graphsync shouldn't do message sytax validation, b/c if it does then the messages won't be available to block syntax validation.