Improve clarity that the dashboard is loading data and not broken

filecoin-saturn / L1-dashboard

https://dashboard.saturn.tech

Other

6 stars 4 forks source link

Improve clarity that the dashboard is loading data and not broken #52

Closed gitstart closed 1 year ago

gitstart commented 1 year ago

What does this PR do?

It improves clarity that the dashboard is loading data and not broken

Issue reference

https://github.com/filecoin-saturn/L1-dashboard/issues/39

Demo video/scrennshot:

https://jam.dev/c/0c90672a-b2f8-41ce-864b-0270d1ebfcda

gitstart commented 1 year ago

@guanzo @joaosa @DiegoRBaquero this PR is ready for review

gitstart commented 1 year ago

Hello nice to meet you. We are GitStart building a service for engineering teams to assign tickets and get back PRs. We'd appreciate if you'd read our PR. If at first glance it doesn't look at all like something you'd merge, please simply send us a "nope" and we'll figure out why ourselves with the help of our mentors. Our goal is for you not to spend time on totally off-road PRs. However if the PR interests you, please proceed like you always do. You can always reach us via support@gitstart.com for any feedback or questions. Thank you!

guanzo commented 1 year ago

On the top right chart, "No Rows To Show" should be replaced with a loading spinner when it's loading.

The top left chart looks a bit weird because the loading icon is off center. My suggestion is to hide the text while loading, and put the loading icon in the center. When it's done loading, make the text visible again.

Basically, all charts should look similar while loading, mainly the loading icon should be centered.

gitstart commented 1 year ago

On the top right chart, "No Rows To Show" should be replaced with a loading spinner when it's loading.

The top left chart looks a bit weird because the loading icon is off center. My suggestion is to hide the text while loading, and put the loading icon in the center. When it's done loading, make the text visible again.

Basically, all charts should look similar while loading, mainly the loading icon should be centered.

We're on it

gitstart commented 1 year ago

On the top right chart, "No Rows To Show" should be replaced with a loading spinner when it's loading.

The top left chart looks a bit weird because the loading icon is off center. My suggestion is to hide the text while loading, and put the loading icon in the center. When it's done loading, make the text visible again.

Basically, all charts should look similar while loading, mainly the loading icon should be centered.

Loom video for the new updates pushed https://www.loom.com/share/f6860500e0f1420dbf54be274f7efea5?sid=471fe11e-2497-4e3d-9619-a85b6065c3a4

guanzo commented 1 year ago

looks great, thanks!