search

filecoin-saturn / contracts

contracts
6 stars 0 forks source link

Minor: Inconsistent CLI arguments between `inspect-earnings` and `claim` sub-commands #69

Open vorburger opened 1 year ago

vorburger commented 1 year ago

saturn-contracts inspect-earnings --address $NODE_FIL_ADDRESS --factory-address $CONTRACT_FIL_ADDRESS

VS.

saturn-contracts claim --addr-to-claim $NODE_FIL_ADDRESS --factory-addr $CONTRACT_FIL_ADDRESS --method ...

when perhaps this (TBD) would be more consistent:

saturn-contracts claim --address $NODE_FIL_ADDRESS --factory-address $CONTRACT_FIL_ADDRESS --method ...

BTW https://docs.saturn.tech/claim-your-rewards erroneously show --factory-address instead of (currently) --factory-addr for claim.

@AmeanAsad

AmeanAsad commented 1 year ago

We should change this for consistency, will publish a PR shortly for this.