search

filecoin-saturn / contracts

contracts
6 stars 0 forks source link

Rename payouts failure file #81

Closed joaosa closed 4 months ago

joaosa commented 4 months ago

It makes more sense for the output file to be called SuccessfulPayouts since it contains the addresses that have been paid and not those which failed.

I left everything else the same.

joaosa commented 4 months ago

I think we should probably give each of these cases different names - we can make it easier to understand exactly where the process failed AND give the operator better intuition about whether the transaction actually made it to a validator... what do you think?

You make excellent points. Indeed all failures happen in different contexts. I took your suggestions and modified filenames accordingly. Also extracted a function for that to keep it DRY.

Also, given that all failure filenames are going to be different it makes sense to sort them based on when they occurred, so I moved the timestamp before the filename. Wdyt?

travis commented 4 months ago

sounds great - I've approved, thanks!