filecoin-station / desktop

Station is a visionary desktop app that connects your computer’s idle resources to the Filecoin network and rewards you with FIL. Taking part is simple, just launch the app and start earning.
https://www.filstation.app
Other
58 stars 11 forks source link

Move from keytar to Electron's safeStorage API. #1656

Open bajtos opened 1 week ago

bajtos commented 1 week ago

keytar is no longer maintained as of Dec 2022, see https://github.com/atom/node-keytar/issues/482.

Other projects like VS Code solved the problem by moving to Electron's safeStorage API, see https://code.visualstudio.com/updates/v1_80#_secretstorage-api-now-uses-electron-api-over-keytar

We should follow their lead and to the same.

Example pull request for inspiration: https://github.com/jfrog/jfrog-vscode-extension/pull/417

We must be extra careful when implementing this change, since we use keytar to store the wallet seed. If we mess this up, the user won't have access to their wallet & rewards earned.