Support Apple Silicon M1/M2 (darwin arm64)

filecoin-station / desktop

Station is a visionary desktop app that connects your computer’s idle resources to the Filecoin network and rewards you with FIL. Taking part is simple, just launch the app and start earning.

https://www.filstation.app

Other

60 stars 13 forks source link

Support Apple Silicon M1/M2 (darwin arm64) #35

Closed bajtos closed 8 months ago

bajtos commented 2 years ago

Improve our build & release setup to produce binaries for darwin-arm64 platform in addition to darwin-x86_64.

Related info:

https://github.com/electron-userland/electron-builder/pull/5426#issuecomment-749684326
Example PR adding M1 support to a different project: https://github.com/athensresearch/athens/pull/707

Consider building a universal binary that supports both architectures - see https://github.com/electron/universal

bajtos commented 2 years ago

I think we will need to update saturn-l2 release process to notarise the arm64 binary.

See https://github.com/golang/go/issues/42684, https://github.com/goreleaser/goreleaser/issues/1227,https://github.com/vercel/pkg/issues/1243 and https://goreleaser.com/customization/sign/?h=gon#with-gon

bajtos commented 2 years ago

I opened an issue to fix saturn-l2 darwin-arm64 builds here: https://github.com/filecoin-project/saturn-l2/issues/35

juliangruber commented 1 year ago

Won't happen in this sprint, as I'm having apple credential issues, and we don't yet have our own credentials

bajtos commented 8 months ago

IIRC, we have already implemented the necessary changes and this GH issue can be closed as done.

@juliangruber feel free to open follow-up issue(s) for any improvements or bugs you are aware of.