search

filecoin-station / desktop

Station is a visionary desktop app that connects your computer’s idle resources to the Filecoin network and rewards you with FIL. Taking part is simple, just launch the app and start earning.
https://www.filstation.app
Other
60 stars 13 forks source link

Should we change the app id `io.filecoin.station`? #492

Open bajtos opened 1 year ago

bajtos commented 1 year ago

Quoting from https://github.com/filecoin-station/filecoin-station/issues/284#issuecomment-1424933069:

$ tail ~/Library/Caches/io.filecoin.station.ShipIt/ShipIt_stderr.log
...

The directory name looks wrong to me, since the Station no longer lives under filecoin.io domain.

Should we change it to something like app.filstation or app.filecoin-station?

Few places where we are using this string:

juliangruber commented 1 year ago

I wonder if this could break auto updates once more. Definitely needs to be investigated. Otherwise, +1

From https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html#//apple_ref/doc/uid/20001431-102070

Launch Services uses the bundle identifier to locate an app capable of opening a particular file

This might break launch on boot, also needs to be investigated

The string should also be in reverse-DNS format. For example, if your company’s domain is Ajax.com and you create an app named Hello, you could assign the string com.Ajax.Hello as your app’s bundle identifier.

Looks like app.filstation.station would accord with Apple's guidelines.

bajtos commented 1 year ago

The string should also be in reverse-DNS format. For example, if your company’s domain is Ajax.com and you create an app named Hello, you could assign the string com.Ajax.Hello as your app’s bundle identifier.

Looks like app.filstation.station would accord with Apple's guidelines.

Considering the recent naming changes, I am proposing t use app.filstation.desktop for Filecoin Station Desktop.

I am going to use app.filstation.zinnia for our runtime. (see https://github.com/filecoin-station/zinnia/issues/23)