search

filecoin-station / spark-stats

API exposing public statistics about Spark
Other
0 stars 1 forks source link

Types: Ensure correct db is passed #185

Closed juliangruber closed 3 months ago

bajtos commented 3 months ago

@juliangruber PTAL.

I have two versions to pick from - the first one uses getNamedPool helper (up to the commit c2fb0d3), the second one calls Object.assign directly (the final version). I am fine with both of them, which one do you like more?

juliangruber commented 3 months ago

Awesome thank you! I like the one without the helper more, since its logic is so simple