search

filepicker / filepicker-django

A django plugin to make integrating with Filepicker.io even easier
Other
93 stars 29 forks source link

Add FPUrlField to get the filepicker URL #5

Closed jonasvp closed 12 years ago

jonasvp commented 12 years ago

For our project, I just need the plain URL to the filepicker file, not a file object. I added a FPUrlField which FPFileFIeld now inherits from.

This commit should be completely backwards-compatible. Hope you like it, I'll be happy to refactor if needed.

Jonas

brettcvz commented 12 years ago

Elegant. LGTM. I'll push a new build to pip as well. Thanks for the PR

brettcvz commented 12 years ago

Unfortunately it looks like this breaks form validation because URLField insists that the cleaned data is a url, whereas FileFiled insists that the cleaned data is a File object. I'll pull them apart

jonasvp commented 12 years ago

Ouch, sorry... thanks for fixing it.

brettcvz commented 12 years ago

No problem

On Tue, Oct 2, 2012 at 1:24 PM, Jonas notifications@github.com wrote:

Ouch, sorry... thanks for fixing it.

— Reply to this email directly or view it on GitHubhttps://github.com/Filepicker/django-filepicker/pull/5#issuecomment-9085470.