search

filepicker / filepicker-js

Filepicker javascript library
38 stars 15 forks source link

Please don't attach to window when module.exports is available #56

Closed zimme closed 7 years ago

zimme commented 7 years ago

By always attaching to window this package is polluting the global namespace in my app.

It would be nice if this package wouldn't attach to window when module.exports is available.

i.e. when using browserify or Meteor.

zimme commented 7 years ago

So when I was removing filepicker manually from window after importing it I realized that filepicker seems to be relying on window.filepicker for its internal functionality which seems like bad design from where I'm standing.

zimme commented 7 years ago

Closing this as filestack-js is the way forward I guess.