search

filerjs / filer

Node-like file system for browsers
BSD 2-Clause "Simplified" License
621 stars 154 forks source link

Addressed Issue #703 #711

Closed dcoull closed 5 years ago

dcoull commented 5 years ago

Updated variable declarations in times.spec.js from var to let and const. All tests passed

codecov-io commented 5 years ago

Codecov Report

Merging #711 into master will increase coverage by <.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
+ Coverage   86.71%   86.71%   +<.01%     
==========================================
  Files          16       16              
  Lines        1746     1739       -7     
==========================================
- Hits         1514     1508       -6     
+ Misses        232      231       -1
Impacted Files Coverage Δ
src/filesystem/interface.js 93.29% <0%> (-0.39%) :arrow_down:
src/stats.js 100% <0%> (ø) :arrow_up:
src/fs-watcher.js 92.3% <0%> (ø) :arrow_up:
src/shell/environment.js 100% <0%> (ø) :arrow_up:
src/filesystem/implementation.js 83.86% <0%> (+0.13%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26b47ee...4c56c33. Read the comment docs.

ndngo commented 5 years ago

Some variables that were declared with let could be declared with const but this is more stylistic preference. Nice job! 💯

humphd commented 5 years ago

@dcoull how is this coming?

dcoull commented 5 years ago

@dcoull how is this coming?

Changes made as requested

humphd commented 5 years ago

@dcoull this still didn't work, maybe we should try this together when we see each other tomorrow. Can you bring your laptop and we do it together?