search

filerjs / filer

Node-like file system for browsers
BSD 2-Clause "Simplified" License
617 stars 154 forks source link

'Use strict' @top and updated the file with const/let [issue-702] #726

Closed SahibArora closed 5 years ago

SahibArora commented 5 years ago

Added strict mode in filer.spec.js Learn more about strict > https://www.w3schools.com/js/js_strict.asp

var abs = "..";

// changed to 

const abs = "..";
// Variables which are objects of library are changed to const and rest are changed to let.

Please advice if I missed something. Thank you

codecov-io commented 5 years ago

Codecov Report

Merging #726 into master will decrease coverage by 0.07%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
- Coverage   86.71%   86.63%   -0.08%     
==========================================
  Files          16       16              
  Lines        1746     1736      -10     
==========================================
- Hits         1514     1504      -10     
  Misses        232      232
Impacted Files Coverage Δ
src/filesystem/interface.js 93.29% <0%> (-0.39%) :arrow_down:
src/fs-watcher.js 92.3% <0%> (ø) :arrow_up:
src/shell/environment.js 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26b47ee...8bcbdbc. Read the comment docs.

SahibArora commented 5 years ago

done!

humphd commented 5 years ago

One tip @SahibArora: you use [issue-702] in your issue above, but it would be better to say Fixes #702, which GitHub will use to auto-close your bug when this PR lands. Next time!