search

filerjs / filer

Node-like file system for browsers
BSD 2-Clause "Simplified" License
617 stars 154 forks source link

Issue #715 Update fs.lstat.spec.js to have proper const and let instead of var and added 'use strict' #727

Closed hoaianhkhang closed 5 years ago

hoaianhkhang commented 5 years ago

I edit the code to change some let into const and tested it again

codecov-io commented 5 years ago

Codecov Report

Merging #727 into master will decrease coverage by 0.07%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
- Coverage   86.71%   86.63%   -0.08%     
==========================================
  Files          16       16              
  Lines        1746     1736      -10     
==========================================
- Hits         1514     1504      -10     
  Misses        232      232
Impacted Files Coverage Δ
src/filesystem/interface.js 93.29% <0%> (-0.39%) :arrow_down:
src/stats.js 100% <0%> (ø) :arrow_up:
src/fs-watcher.js 92.3% <0%> (ø) :arrow_up:
src/shell/environment.js 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26b47ee...fbdd179. Read the comment docs.

pbrahmbhatt3 commented 5 years ago

Hi @hoaianhkhang, good work! I think you can make your pull request better by giving some desciption of the changes you have made. if you click on the 3 horizontal dots you will be given an option to edit your description and you can describe your changes. untitled

hoaianhkhang commented 5 years ago

I have changed the file, can you check it again please?