search

filerjs / filer

Node-like file system for browsers
BSD 2-Clause "Simplified" License
617 stars 154 forks source link

Issue 710 fixed #729

Closed abdiG closed 5 years ago

abdiG commented 5 years ago

In file filer/tests/spec/fs.exists.spec.js i changed var to let and added 'use strick'

codecov-io commented 5 years ago

Codecov Report

Merging #729 into master will decrease coverage by 0.11%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #729      +/-   ##
=========================================
- Coverage   86.71%   86.6%   -0.12%     
=========================================
  Files          16      16              
  Lines        1746    1739       -7     
=========================================
- Hits         1514    1506       -8     
- Misses        232     233       +1
Impacted Files Coverage Δ
src/filesystem/interface.js 93.29% <0%> (-0.39%) :arrow_down:
src/filesystem/implementation.js 83.68% <0%> (-0.05%) :arrow_down:
src/stats.js 100% <0%> (ø) :arrow_up:
src/fs-watcher.js 92.3% <0%> (ø) :arrow_up:
src/shell/environment.js 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26b47ee...6f376ae. Read the comment docs.

kwchan19 commented 5 years ago

I'm seeing that you used 'let' for all of the variables. It would be better to use 'const', as the variables do not change values.

humphd commented 5 years ago

@abdiG how is this coming?

humphd commented 5 years ago

@abdiG how is this coming?

abdiG commented 5 years ago

@humphd I have made all the changes you asked. And sorry it took a while.

humphd commented 5 years ago

Fix and merged in https://github.com/filerjs/filer/commit/3d10d6431c853d69006a42257620b818e875b8d1