search

filerjs / filer

Node-like file system for browsers
BSD 2-Clause "Simplified" License
617 stars 154 forks source link

Issue#719: Updated var to const/let #731

Closed ael-mas closed 5 years ago

ael-mas commented 5 years ago

Updated var declarations to use const or let instead. Added strict mode to file.

codecov-io commented 5 years ago

Codecov Report

Merging #731 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #731   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          16       16           
  Lines        1746     1746           
=======================================
  Hits         1514     1514           
  Misses        232      232

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26b47ee...b9eb646. Read the comment docs.

humphd commented 5 years ago

@ael-mas how is this coming? Any update?

humphd commented 5 years ago

@ael-mas did you want this PR closed in favour of the new one you opened?

ael-mas commented 5 years ago

The new one should have the correct variable declarations using const instead of let. Apologies if I didn't modify my original changes properly on github.

humphd commented 5 years ago

OK, no problem. Closing in favour of #741. In future, you can just make more commits and push to your same branch, and it will add to/update an existing PR vs. making a new one.