search

filerjs / filer

Node-like file system for browsers
BSD 2-Clause "Simplified" License
621 stars 154 forks source link

Fix #736: use ms vs. s resolution on all times #739

Closed humphd closed 5 years ago

humphd commented 5 years ago

This corrects my mistake when porting node's time handling code. They assume seconds in a lot of places, and have to multiply/divide by 1000 to get proper units. We always use ms times, so this fixes things everywhere. I've added better test coverage for it too.

codecov-io commented 5 years ago

Codecov Report

Merging #739 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #739   +/-   ##
=======================================
  Coverage   86.63%   86.63%           
=======================================
  Files          16       16           
  Lines        1736     1736           
=======================================
  Hits         1504     1504           
  Misses        232      232
Impacted Files Coverage Δ
src/stats.js 100% <100%> (ø) :arrow_up:
src/filesystem/implementation.js 83.72% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0ec51a1...9b496e7. Read the comment docs.