CDNRae commented 5 years ago

Fixes #627 by adding 3 tests to fs.write():

Test that tries to use a non-existent fd
Test that tries to open a file without the O_WRITE flag and then call fs.write
Test that tries to write a buffer whose length is too small (buffer.length - offset < length)

codecov-io commented 5 years ago

Codecov Report

Merging #746 into master will increase coverage by 0.17%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #746      +/-   ##
==========================================
+ Coverage   86.71%   86.88%   +0.17%     
==========================================
  Files          16       16              
  Lines        1739     1739              
==========================================
+ Hits         1508     1511       +3     
+ Misses        231      228       -3

Impacted Files	Coverage Δ
src/filesystem/implementation.js	`84.13% <0%> (+0.27%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 94d5ff8...01f3f1c. Read the comment docs.

CDNRae commented 5 years ago

Made the changes -- hope these are good to go! Thanks for reviewing my work!

filerjs / filer

Issue 627 #746

Codecov Report