search

filerjs / filer

Node-like file system for browsers
BSD 2-Clause "Simplified" License
617 stars 154 forks source link

Implement lchown 620 #750

Closed andrewkoung closed 5 years ago

andrewkoung commented 5 years ago

Worked on implementing lchown(). Let me know know what you think about the code.

andrewkoung commented 5 years ago

Could you let me know why my commits from my other pull request is being shown here? I created another branch for this issue, so I'm not sure why it's doing this.

humphd commented 5 years ago

When you made your new branch, where were you? On your old branch? If so, it will create it based on that old work.

$ git checkout old-branch
$ git checkout -b new-branch
# new-branch now includes everything in old-branch
$ git checkout -b new-branch master
# new-branch is now based off master

You can also just rebase this branch, and then push it up to replace what's here:

$ git checkout master
$ git pull upstream master
$ git checkout implement-lchown-620
$ git rebase master
$ git push origin implement-lchown-620 -f
andrewkoung commented 5 years ago

Sounds good. I'll remove this PR and have a new one up.