search

filerjs / filer

Node-like file system for browsers
BSD 2-Clause "Simplified" License
617 stars 154 forks source link

Fix #749, #620: implement lchown() #752

Open andrewkoung opened 5 years ago

andrewkoung commented 5 years ago

Let me know if my logic was wrong, but I believe this was the correct flow.

codecov-io commented 5 years ago

Codecov Report

Merging #752 into master will increase coverage by 0.03%. The diff coverage is 87.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #752      +/-   ##
==========================================
+ Coverage   86.88%   86.92%   +0.03%     
==========================================
  Files          16       16              
  Lines        1739     1751      +12     
==========================================
+ Hits         1511     1522      +11     
- Misses        228      229       +1
Impacted Files Coverage Δ
src/filesystem/interface.js 93.29% <ø> (ø) :arrow_up:
src/filesystem/implementation.js 84.21% <87.09%> (+0.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4aae538...34434b0. Read the comment docs.

humphd commented 5 years ago

Updated the title of this PR, since it will fix #749, #620.

andrewkoung commented 5 years ago

There happens to be a test for chown() already, but I've created the test for lchown()!