search

filerjs / filer

Node-like file system for browsers
BSD 2-Clause "Simplified" License
621 stars 154 forks source link

Shell.mkdirp does not support relative paths #755

Closed SillyFreak closed 4 years ago

SillyFreak commented 4 years ago

exactly as the title says. trying it gives me (EINVAL): Path must be absolute.

As a workaround, replacing path by Path.resolve(sh.pwd(), path) works of course.

humphd commented 4 years ago

Looks like we're missing a call to Path.resolve(sh.pwd(), path) in mkdirp.

SillyFreak commented 4 years ago

hey @humphd, I'm back :P

If you don't mind, I'll try and create a PR for this; I have never before contributed to someone else's project beyond reporting bugs and would like to get into the habit. I've read the CONTRIBUTING.md and will try to create a fitting test case for the fix.

humphd commented 4 years ago

@SillyFreak sounds good. If you need help getting things to work, let me know.

humphd commented 4 years ago

v1.2.0 Released!

Thanks for contributing.