Closed bcheidemann closed 3 years ago
Merging #767 (caa5dc2) into master (c0a41d6) will increase coverage by
0.16%
. The diff coverage is96.66%
.
@@ Coverage Diff @@
## master #767 +/- ##
==========================================
+ Coverage 86.89% 87.06% +0.16%
==========================================
Files 16 20 +4
Lines 1740 1770 +30
==========================================
+ Hits 1512 1541 +29
- Misses 228 229 +1
Impacted Files | Coverage Δ | |
---|---|---|
shims/fs.js | 95.83% <95.83%> (ø) |
|
shims/buffer.js | 100.00% <100.00%> (ø) |
|
shims/path.js | 100.00% <100.00%> (ø) |
|
shims/providers/default.js | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update aacc806...caa5dc2. Read the comment docs.
I fixed CI on master to avoid this random build failure. Can you rebase this so it runs through to completion?
I fixed CI on master to avoid this random build failure. Can you rebase this so it runs through to completion?
Done =)
Can you revert the changes to
package-lock.json
andtests/spec/filer.spec.js
, which aren't necessary for this fix? In general we don't want to include unrelated changes in commits.git checkout master tests/spec/filer.spec.js git checkout master package-lock.json ...etc
The rest looks great.
No problem 👍
I've made the requested changes
Resolves issue: https://github.com/filerjs/filer/issues/766
@humphd