filerjs / filer

Node-like file system for browsers
BSD 2-Clause "Simplified" License
613 stars 153 forks source link

Fix issue #766: Remove describe.only from shim tests #767

Closed bcheidemann closed 3 years ago

bcheidemann commented 3 years ago

Resolves issue: https://github.com/filerjs/filer/issues/766

@humphd

codecov-io commented 3 years ago

Codecov Report

Merging #767 (caa5dc2) into master (c0a41d6) will increase coverage by 0.16%. The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #767      +/-   ##
==========================================
+ Coverage   86.89%   87.06%   +0.16%     
==========================================
  Files          16       20       +4     
  Lines        1740     1770      +30     
==========================================
+ Hits         1512     1541      +29     
- Misses        228      229       +1     
Impacted Files Coverage Δ
shims/fs.js 95.83% <95.83%> (ø)
shims/buffer.js 100.00% <100.00%> (ø)
shims/path.js 100.00% <100.00%> (ø)
shims/providers/default.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aacc806...caa5dc2. Read the comment docs.

humphd commented 3 years ago

I fixed CI on master to avoid this random build failure. Can you rebase this so it runs through to completion?

bcheidemann commented 3 years ago

I fixed CI on master to avoid this random build failure. Can you rebase this so it runs through to completion?

Done =)

bcheidemann commented 3 years ago

Can you revert the changes to package-lock.json and tests/spec/filer.spec.js, which aren't necessary for this fix? In general we don't want to include unrelated changes in commits.


git checkout master tests/spec/filer.spec.js

git checkout master package-lock.json

...etc

The rest looks great.

No problem 👍

bcheidemann commented 3 years ago

I've made the requested changes