Closed bcheidemann closed 3 years ago
I still think a test that uses webpack to do the build would be smart, since all of these shims are aimed at using it in that context, otherwise regressions are going to happen where we break those builds and expectations.
I still think a test that uses webpack to do the build would be smart, since all of these shims are aimed at using it in that context, otherwise regressions are going to happen where we break those builds and expectations.
Something like this? https://github.com/filerjs/filer/pull/770
This PR corrects an error in the Buffer shim documentation. Using webpack.ProvidePlugin as previously documented would result in Buffer being globally defined as:
{ __esModule: true, default: ..., Buffer: ... }
The update to the documentation results in Buffer being resolved correctly by webpack.