search

filerjs / filer

Node-like file system for browsers
BSD 2-Clause "Simplified" License
613 stars 153 forks source link

WIP: Build and run tests with webpack #770

Open bcheidemann opened 3 years ago

bcheidemann commented 3 years ago

Adds the option to build and run tests with webpack using the command npm run test:webpack. (Similar to npm run test:manual in that it spins up a local server)

bcheidemann commented 3 years ago

@humphd Is this the kind of thing you were talking about?

codecov-io commented 3 years ago

Codecov Report

Merging #770 (05ea9e7) into master (c0a41d6) will increase coverage by 0.16%. The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #770      +/-   ##
==========================================
+ Coverage   86.89%   87.06%   +0.16%     
==========================================
  Files          16       20       +4     
  Lines        1740     1770      +30     
==========================================
+ Hits         1512     1541      +29     
- Misses        228      229       +1
Impacted Files Coverage Δ
shims/fs.js 95.83% <95.83%> (ø)
shims/buffer.js 100.00% <100.00%> (ø)
shims/path.js 100.00% <100.00%> (ø)
shims/providers/default.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f8c9732...05ea9e7. Read the comment docs.

humphd commented 3 years ago

Ping me when you want reviews on these.

bcheidemann commented 3 years ago

No problem 👍

bcheidemann commented 3 years ago

Ping me when you want reviews on these.

I will come back to these after #771 is merged as I think it makes sense to use the webpack plugin to build these tests. Also, if we move the plugin to it's own repo (as discussed in #771) would you want to move these tests to that repo or leave them here?

humphd commented 3 years ago

I think doing it in this repo is probably the best idea, since it has CI setup already, and is so closely related to the other code. I'm more wondering about reducing the bundle size for Filer for cases where people aren't using the webpack plugin. We could write a separate set of build/test scripts to be run with npm-run-all or something that builds it beside vs. as part of Filer.