search

filerjs / filer

Node-like file system for browsers
BSD 2-Clause "Simplified" License
613 stars 153 forks source link

Fix issue #775 #778

Closed bcheidemann closed 3 years ago

bcheidemann commented 3 years ago

Adds regression test and closes #775

humphd commented 3 years ago

Same deal here, this needs a rebase.

bcheidemann commented 3 years ago

I've done a rebase here too but will probably need to redo once #777 is merged as there will likely be conflicts.

codecov-commenter commented 3 years ago

Codecov Report

Merging #778 (6210cf6) into master (21e7a47) will increase coverage by 0.17%. The diff coverage is 91.48%.

:exclamation: Current head 6210cf6 differs from pull request most recent head ccc0e5b. Consider uploading reports for the commit ccc0e5b to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
+ Coverage   87.32%   87.50%   +0.17%     
==========================================
  Files          23       24       +1     
  Lines        1831     1873      +42     
==========================================
+ Hits         1599     1639      +40     
- Misses        232      234       +2
Impacted Files Coverage Δ
src/filesystem/implementation.js 84.41% <90.47%> (+0.34%) :arrow_up:
src/dirent.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21e7a47...ccc0e5b. Read the comment docs.

bcheidemann commented 3 years ago

@humphd I've updated the readdir function to accept an options object - behaviour should be consistent with node fs.readdir except I haven't implemented the withFileTypes option yet. Will rename the pr and add WIP prefix.

bcheidemann commented 3 years ago

@humphd I've done a rebase and added implementation for handling the withFileTypes option. Should be good to merge if you're happy with it =)

bcheidemann commented 3 years ago

Looks good, nice work.

Can you update the README in this same PR for the options and withFileTypes additions?

No problem 👌

bcheidemann commented 3 years ago

@humphd updated the README =)