files-community / Files

A modern file manager that helps users organize their files and folders.
https://files.community
MIT License
34.52k stars 2.2k forks source link

Bug: Actions with dropdown not displaying correctly in "..." dropdown of the Toolbar #10291

Open QuaintMako opened 2 years ago

QuaintMako commented 2 years ago

Description

When Files' window is small enough to force the toolbar actions to collapse into a "..." dropdown, some actions are not displaying correctly inside of it.

It seems to be specifically the actions leading to another dropdown : Set As Background, Extract etc...

Steps To Reproduce

In the case of an image :

  1. Reduce the size of the app window until the toolbar actions are collapsed into a "..." button.
  2. Select an image.
  3. Click on the "..." and observe the "Set as background" button.

Steps to fix

Files Version

Version: 2.3.48.0 OS

Windows Version

W11 21H2 22000.1098

Relevant Assets/Logs

SetAsBackgroundToolbar

QuaintMako commented 2 years ago

We can see that the dropdown arrow is aligned on the left. It may be linked to it?

yaira2 commented 2 years ago

It's likely a result of the custom style those drowdowns use. It'll take some work to fix but it's an issue nontheless.

0x5bfa commented 4 months ago

As we do for MenuFlyoutItem, we might want to create custom style with a custom dependnecy object for AppBarButton.