files-community / Files

A modern file manager that helps users organize their files and folders.
https://files.community
MIT License
34.22k stars 2.18k forks source link

Code Quality: Duplication in DetailsLayoutBrowser, ColumnViewBase and GridViewBrowser #10305

Open QuaintMako opened 1 year ago

QuaintMako commented 1 year ago

Description

Some code is duplicated between DetailsLayoutBrowser.xaml.cs,GridViewBrowser.xaml.csandColumnViewBase.xaml.cs`. Sometimes it's entire methods, sometimes it's only partial bits.

These classes are already inheriting from BaseLayout.cs. The duplicated code may be better hoisted inside this class.

Concerned code

Gains

Requirements

Comments

No response

QuaintMako commented 1 year ago

The current plan of action for the refactorings are as follow: