files-community / Files

A modern file manager that helps users organize their files and folders.
https://files.community
MIT License
34.52k stars 2.2k forks source link

Feature: Don't force permeant delete if and ADS file is attached to a normal file getting deleted #10849

Open Josh65-2201 opened 1 year ago

Josh65-2201 commented 1 year ago

What feature or improvement do you think would benefit Files?

If I have a file select for deletion if can go into the recycling bin like normal. But with Show ADS files turned on and I select all and delete permeant delete is forced. Even though deleting the normal file can move it to the recycle bin along with the ADS attachment.

Requirements

I think this could be done with two stages. One to show the main files getting deleted, then another for any left over ADS files that were select both following Files settings > Folders > Show confirmation dialog when deleting items setting

Files Version

2.4.8.0

Windows Version

10.0.22621.965

Comments

No response

yaira2 commented 1 year ago

What's the expected behavior here?

Josh65-2201 commented 1 year ago

I would expect the files deleted to be move to the recycle bin like if the show ADS files option was off. Since ADS files are move/deleted when the normal files are moved to the recycle bin. I updated the main issue to hopefully make it more clear on what I mean and would expect to happen