files-community / Files

A modern file manager that helps users organize their files and folders.
https://files.community
MIT License
34.19k stars 2.18k forks source link

Bug: Old unused shared drives appear in Files #11603

Open Nirav1633 opened 1 year ago

Nirav1633 commented 1 year ago

Description

When navigating in the side bar between different share drives, old unused share drives appear as broken drives

Steps To Reproduce

  1. open files app
  2. navigate between share drives in the navigation bar
  3. old drives that you no longer have permission for or that where unmounted appear (also remounts the drives in file explorer)
  4. the random share drives are broken or empty
  5. FYI this was tested on multiple machines with multiple users with same issue and same fix

Screenshot 2023-03-07 175925

Steps to fix

1 close files app 2 open windows file explorer 3 unmount drives from file explorer 4 open files app 5 old drives are not longer there 6 repeat steps in "steps to reproduce" and issue comes back Screenshot 2023-03-07 180548

Files Version

2.4.40.0

Windows Version

Windows 11 22H2

Log file

debug.log

yaira2 commented 11 months ago

@Nirav1633 do the drives go away if you restart Windows?

Nirav1633 commented 11 months ago

Yair

thanks for getting back to me

im typing on my phone so excuse grammer and spelling mistakes.

essentially this is share drive issue i have noticed two issues around this

Some background: I use files in an enterprise environment. i do not believe any user who is using files for individual purposes would run into this issue.

If I tag a file or folder in a share drive like "IT Drive" or "HR Drive" I tag the file, see it in the tag widget. Now if i close the files app, and disconnect from my office network, go home, and open files before i reconnect to my office network using vpn the tags do not show up in the widget anymore. i need to navigate to the IT drive or HR drive, once the file appears in the files app and i see the tag in the column. if I then go back to files "home" then i see the files/folders in the tag widget.

If imay i think what is happening is

the tag feature creates a cache location from the file/folder on the share drive to the tag widget, not sure if this is unc path or some other way of making this connection. when i open files and there is no direct connection to this folder as in office network or vpn. the connection is not completed and the tag dies in the widget. i know this because if I open the files app while not on my company network, any local file i have tagged like form downloads or documents, those files are in the tag widget, any file i have tagged form the share drive is not.

the other issue im having is any drive that i had access to but not longer do is showing up in files if i navigate on the left sidebar from one share drive to another. for instance i have access to 4 drives currently, i had access to 5th drive that i no longer need, and access was removed and drive disconnected. if i go from one share drive to another the 5th drive pops up in the left side bar but it is empty, almost like a ghost drive. i have changed 4 computers since using the files app and the issue comes across every time. not sure if the files app is reading some kind of meta data from my active directory account.

these are hard issues to explain in text, if you want i can reproduce these and send you a video, which would be much easier to understand.

Also im a desktop and cloud engineer, not a programmer so sorry for not using the proper vocabulary when explaining the issue to a developer

I work for a vsmall enterprise and we love the files app, we were even thinking of using it across the firm and reaching out to you guys for some bulk agreement so we can pay to use the app and help out your files community with a contribution. However with these two issues and the fact that MS is copying some of your features, we put these plans on hold but are waiting to see if files work better in the future.

Thanks Nirav

On Sun, Nov 12, 2023, 11:59 AM Yair @.***> wrote:

@Nirav1633 https://github.com/Nirav1633 do the drives go away if you restart Windows?

— Reply to this email directly, view it on GitHub https://github.com/files-community/Files/issues/11603#issuecomment-1807183215, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6F2C7TBKLC4CFJ4XQZBQDTYED56XAVCNFSM6AAAAAAVTCW7ZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBXGE4DGMRRGU . You are receiving this because you were mentioned.Message ID: @.***>

yaira2 commented 11 months ago

Thanks for the response, we're tracking the issue with the tags widget in #13502. Regarding the other issue, can you confirm if the drives were unmounted while the app was running?

Nirav1633 commented 11 months ago

The drives where not unmounted

On Sun, Nov 12, 2023, 2:08 PM Yair @.***> wrote:

Thanks for the response, we're tracking the issue with the tags widget in

13502 https://github.com/files-community/Files/issues/13502. Regarding

the other issue, can you confirm if the drives were unmounted while the app was running?

— Reply to this email directly, view it on GitHub https://github.com/files-community/Files/issues/11603#issuecomment-1807213003, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6F2C7XJR43A2PMUXLGNDULYEENB5AVCNFSM6AAAAAAVTCW7ZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBXGIYTGMBQGM . You are receiving this because you were mentioned.Message ID: @.***>

yaira2 commented 11 months ago

old drives that you no longer have permission for or that where unmounted appear (also remounts the drives in file explorer)

Can you clarify this step?

Nirav1633 commented 11 months ago

Please see link below, it's a short 50 second video on the issue, if you cannot see it I will make a more detail text of the issue with screenshots

https://photos.app.goo.gl/7tgw16mjG17yLzkp6

On Sun, Nov 12, 2023, 2:10 PM Yair @.***> wrote:

old drives that you no longer have permission for or that where unmounted appear (also remounts the drives in file explorer)

Can you clarify this step?

— Reply to this email directly, view it on GitHub https://github.com/files-community/Files/issues/11603#issuecomment-1807213526, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6F2C7SHHFKBVYCMOO2PJUDYEENKFAVCNFSM6AAAAAAVTCW7ZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBXGIYTGNJSGY . You are receiving this because you were mentioned.Message ID: @.***>